Fix edge case in autoscaler with poor bin packing #5702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When the cluster is backlogged, bump the "estimated busy nodes" count by the number of nonidle nodes + 1. This takes into account the case where the head node cannot accept tasks and hence is idle, or more generally, when nodes don't register as fully utilized due to poor bin packing, but there are tasks in a backlog somewhere in the cluster.
One side effect is that we are slightly more aggressive at scaling up, but this is probably ok.
Related issue number
Closes #5696
Checks
scripts/format.sh
to lint the changes in this PR.