DQN support of custom models #6254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ericl
requested changes
Nov 24, 2019
| from ray.rllib.models.tf.misc import normc_initializer, get_activation_fn | ||
| from ray.rllib.utils import try_import_tf | ||
|
|
||
| tf = try_import_tf() | ||
|
|
||
|
|
||
| class FullyConnectedNetwork(TFModelV2): | ||
| class FullyConnectedNetwork(DistributionalQModel): |
There was a problem hiding this comment.
| from ray.rllib.models.tf.visionnet_v2 import VisionNetwork | ||
| from ray.rllib.models.tf.fcnet_v2 import FullyConnectedNetwork | ||
|
|
||
| class DQNCustomModelTest(unittest.TestCase): |
There was a problem hiding this comment.
Instead of adding a new test, can you add an case to https://github.com/ray-project/ray/blob/master/rllib/examples/custom_keras_model.py exercising this instead?
|
Test FAILed. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Prevents circular dependency of custom models when running DQN - #6091.
I also added a test that checks internal custom models for DQN and makes sure it does not accidentally break for other policies.
Related issue number
Closes #6091
Checks
scripts/format.shto lint the changes in this PR.