Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap models with DistributionalQModel when running DQN #6258

Merged
merged 3 commits into from Nov 25, 2019
Merged

wrap models with DistributionalQModel when running DQN #6258

merged 3 commits into from Nov 25, 2019

Conversation

AmeerHajAli
Copy link
Contributor

@AmeerHajAli AmeerHajAli commented Nov 24, 2019

Why are these changes needed?

Prevents circular dependency of custom models when running DQN - #6091.
I also added a test that checks internal custom models for DQN and makes sure it does not accidentally break for other policies. PR after code review of PR #6254.

Related issue number

Closes #6091

Checks

@AmeerHajAli AmeerHajAli mentioned this pull request Nov 24, 2019
3 tasks
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18833/
Test FAILed.

@AmeerHajAli
Copy link
Contributor Author

jenkins, retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18834/
Test FAILed.

@AmeerHajAli
Copy link
Contributor Author

AmeerHajAli commented Nov 24, 2019

I reran the same test that failed (test_checkpoint_restore.py) locally and it passes. :/

@ericl
Copy link
Contributor

ericl commented Nov 24, 2019

jenkins retest this please

1 similar comment
@ericl
Copy link
Contributor

ericl commented Nov 24, 2019

jenkins retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18841/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18852/
Test PASSed.

@ericl ericl merged commit 71316fa into ray-project:master Nov 25, 2019
@ericl
Copy link
Contributor

ericl commented Nov 25, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DQN does not allow custom models
3 participants