New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrap models with DistributionalQModel when running DQN #6258
Conversation
Can one of the admins verify this patch? |
Test FAILed. |
jenkins, retest this please |
Test FAILed. |
I reran the same test that failed (test_checkpoint_restore.py) locally and it passes. :/ |
jenkins retest this please |
1 similar comment
jenkins retest this please |
Test FAILed. |
Test PASSed. |
Merged, thanks! |
Why are these changes needed?
Prevents circular dependency of custom models when running DQN - #6091.
I also added a test that checks internal custom models for DQN and makes sure it does not accidentally break for other policies. PR after code review of PR #6254.
Related issue number
Closes #6091
Checks
scripts/format.sh
to lint the changes in this PR.