[tune] get checkpoints paths for a trial after tuning #6643
Conversation
|
Can one of the admins verify this patch? |
|
Test PASSed. |
|
cc @richardliaw Is this close to what you mentioned? Thanks. |
| """ | ||
| from ray.tune.checkpoint_manager import Checkpoint | ||
|
|
||
| checkpoints = trial.checkpoint_manager.best_checkpoints() |
There was a problem hiding this comment.
this is odd because the user may not have access to the Trial object... maybe we can load the path instead?
There was a problem hiding this comment.
Oh I thought this can be the next step after get_best_trial or just using self.trials. We can load from disk check points given the trial logdir.
Shall we support both? i.e. trial can be a trial or a path, and we take different approaches according to its type.
There was a problem hiding this comment.
Also I assume this should be a static method that can operate without trials in memory
There was a problem hiding this comment.
Ah sorry for the slow reply - supporting both would be ideal. get_best_trial is only available for live experiments (not offline analysis).
|
Thanks for the comments. Updated to find checkpoints from logdir. |
|
Test FAILed. |
hhbyyh
force-pushed
the
checkpointPath
branch
from
cf6741b
to
9c8c850
Compare
|
Sorry for the late reply. Updated to use the checkpoint file. The getting by path part has many hard coded strings, shall we move that part code to TrainableUtil, for reuse and easier change management? |
|
Test FAILed. |
Yes, this sounds like a good idea to me! |
| Arguments: | ||
| trial(Trial): The log directory of a trial, or a trial instance. | ||
| metric (str): key for trial info to return, e.g. "mean_accuracy". | ||
| "training_iteration" is used by default. |
There was a problem hiding this comment.
| "training_iteration" is used by default. | |
| "training_iteration" is used by default. |
|
Test FAILed. |
|
Test FAILed. |
Add a new API in Analysis to fetch the checkpoint paths for a trial.
Checks
scripts/format.shto lint the changes in this PR.