Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[operator] Small bugfixes #7459

Merged
merged 3 commits into from
Mar 5, 2020
Merged

[operator] Small bugfixes #7459

merged 3 commits into from
Mar 5, 2020

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Mar 5, 2020 •
edited
Loading

Why are these changes needed?

Fixes some small issues encountered while trying to run the kubernetes operator:

  • Allow controller image to be specified via kustomize
  • Rename RayClusters to rayclusters in RBAC specification
  • Use rayproject/autoscaler image in examples
  • Remove non-working readiness probe
  • Add ServicePort to head node service

Checks

@edoakes
Copy link
Contributor Author

edoakes commented Mar 5, 2020

cc @gaocegege @Qstar @chenk008

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22751/
Test FAILed.

gaocegege
gaocegege reviewed Mar 5, 2020
View reviewed changes
Copy link
Contributor

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edoakes edoakes merged commit e29f2ef into ray-project:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@robertnishihara robertnishihara robertnishihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edoakes @AmplabJenkins @robertnishihara @gaocegege