[Java] Fix the issue that the cached value in RayObject is serialized
#7613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Test FAILed. |
kfstorm
approved these changes
Mar 16, 2020
ericl
approved these changes
Mar 16, 2020
|
Does it make sense to add a test for serialization? |
|
@ericl I thought about adding a test. But this PR is more like a performance improvement, rather than a bug fix. If we want to add a test, I can only assert the size of the serialized object is small. But this seems weird. So I didn't do that. |
|
Fair enough, I guess you can always assume T is serializable as well.
…On Mon, Mar 16, 2020, 12:05 AM Hao Chen ***@***.***> wrote:
@ericl <https://github.com/ericl> I thought about adding a test. But this
PR is more like a performance improvement, rather than a bug fix. If we
want to add a test, I can only assert the size of the serialized object is
small. But this seems weird. So I didn't do that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7613 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSVXG5LA6QGBT55JI33RHXFUDANCNFSM4LLXIQHA>
.
|
|
Test PASSed. |
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Mar 17, 2020
stephanie-wang
added a commit
that referenced
this pull request
Mar 19, 2020
* enable * Turn on eager eviction * Shorten tests and drain ReferenceCounter * Don't force kill actor handles that have gone out of scope, lint * Fix locks * Cleanup Plasma Async Callback (#7452) * [rllib][tune] fix some nans (#7611) * Change /tmp to platform-specific temporary directory (#7529) * [Serve] UI Improvements (#7569) * bugfix about test_dynres.py (#7615) Co-authored-by: senlin.zsl <senlin.zsl@antfin.com> * Java call Python actor method use actor.call (#7614) * bug fix about useage of absl::flat_hash_map::erase and absl::flat_hash_set::erase (#7633) Co-authored-by: senlin.zsl <senlin.zsl@antfin.com> * [Java] Make both `RayActor` and `RayPyActor` inheriting from `BaseActor` (#7462) * [Java] Fix the issue that the cached value in `RayObject` is serialized (#7613) * Add failure tests to test_reference_counting (#7400) * Fix typo in asyncio documentation (#7602) * Fix segfault * debug * Force kill actor * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
No need to serialize the cached value, just serialize the id.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.