Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix about usage of absl::flat_hash_map::erase and absl::flat_hash_set::erase #7633

Merged

Conversation

wumuzi520
Copy link
Contributor

Why are these changes needed?

It is wrong to use absl::flat_hash_map::erase or absl::flat_hash_set::erase like this:

for (const auto &entry : flat_hash_set) {
   .....
   flat_hash_set.erase(entry);
}

for (auto iter = flat_hash_set.begin(); iter != flat_hash_set.end(); ++iter) {
   .....
   flat_hash_set.erase(iter);
}

The tow above codes will lead to exception.

Related issue number

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@wumuzi520 wumuzi520 force-pushed the bugfix_about_erase_of_flat_hash_container branch from 6e89ac9 to 6f66f1a Compare March 17, 2020 06:07
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23266/
Test PASSed.

@raulchen raulchen changed the title bug fix about useage of absl::flat_hash_map::erase and absl::flat_hash_set::erase bug fix about usage of absl::flat_hash_map::erase and absl::flat_hash_set::erase Mar 17, 2020
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23265/
Test FAILed.

@raulchen raulchen merged commit dfa5d9b into ray-project:master Mar 17, 2020
@raulchen raulchen deleted the bugfix_about_erase_of_flat_hash_container branch March 17, 2020 11:41
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Mar 17, 2020
…h_set::erase (ray-project#7633)

Co-authored-by: senlin.zsl <senlin.zsl@antfin.com>
stephanie-wang added a commit that referenced this pull request Mar 19, 2020
* enable

* Turn on eager eviction

* Shorten tests and drain ReferenceCounter

* Don't force kill actor handles that have gone out of scope, lint

* Fix locks

* Cleanup Plasma Async Callback (#7452)

* [rllib][tune] fix some nans (#7611)

* Change /tmp to platform-specific temporary directory (#7529)

* [Serve] UI Improvements (#7569)

* bugfix about test_dynres.py (#7615)

Co-authored-by: senlin.zsl <senlin.zsl@antfin.com>

* Java call Python actor method use actor.call (#7614)

* bug fix about useage of absl::flat_hash_map::erase and absl::flat_hash_set::erase (#7633)

Co-authored-by: senlin.zsl <senlin.zsl@antfin.com>

* [Java] Make both `RayActor` and `RayPyActor` inheriting from `BaseActor` (#7462)

* [Java] Fix the issue that the cached value in `RayObject` is serialized (#7613)

* Add failure tests to test_reference_counting (#7400)

* Fix typo in asyncio documentation (#7602)

* Fix segfault

* debug

* Force kill actor

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants