-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$env open] -fidexmap default #4
Comments
I just follow the LMDB test code and not think about this. |
I have to double check, but I think this might be the cause for the testsuite failures I see when building in debug mode (--enable-symbols passed to configure). Can you reproduce? |
I can't reproduce. It is still pass on my machine (at openSUSE). |
I'll have a closer look at it and let you know! |
Turns out this wasn't the reason for the failure I was seeing. Investigating that in #5 . |
… to false See the discussion at ray2501/tcl-lmdb#4 and the commit at ray2501/tcl-lmdb@a6fb287. git-svn-id: svn+ssh://svn.freebsd.org/ports/head@414858 35697150-7ecd-e111-bb59-0022644237b5
… to false See the discussion at ray2501/tcl-lmdb#4 and the commit at ray2501/tcl-lmdb@a6fb287.
… to false See the discussion at ray2501/tcl-lmdb#4 and the commit at ray2501/tcl-lmdb@a6fb287.
Hi Danilo,
I see that the
-fixedmap
param toenv open
defaults to true.https://github.com/ray2501/tcl-lmdb/blob/master/generic/tclmdb.c#L1363
This is very risky as
mmap(2)
doesn't guarantee that the address hint is respected.As you only open the env once - when doing
$env open
- and copy data in/out viaTcl_Obj
s, I wonder why you chose to opt for having this default to true.If there's no compelling reason, I think it would be better to change the default to false.
Thanks!
The text was updated successfully, but these errors were encountered: