-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New extension: Open With App #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the contribution!
Everything looks great, but please use .png
icon 512x512
size for the extension as it described in the Guidelines
Hey @mattisssa! Thanks for the feedback. Yeah, I'll provide another icon. But I have two questions:
|
|
@mattisssa I fixed the icon and updated the names according to your suggestions. Edit: I was reviewing this and I found a "Open With…" command in Raycast. So wouldn't it be better to keep the ellipsis at the end of the command name? The ellipsis is common UI element that indicates that you'll have another step in the process, so after hitting "Open With…" you'll have to make another selection before effectively opening something. Without the ellipsis, and with the Finder subtitle, it seems that you'll "Open With Finder": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better 💪
@fturcheti yes, you are right, let's keep it like this "Open With…" 👍 |
- Cleaner getFinderSelection logic - showHUD with warning when invoking the command with nothing selected in Finder
Thanks for the review, @mattisssa. I reverted this naming change, did a small code cleanup, improving the Now we're ready to launch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! 👍
Let's bring it to the Store now.
* New extension: Open Finder Selection With… * Cleaner call for applescript execution * Fix icon and names to better fit the extension guidelines * Open With App: New icon * Open With App: Revert command name change * Open With App: Code cleanup - Cleaner getFinderSelection logic - showHUD with warning when invoking the command with nothing selected in Finder * Open With App: Bug fix for files with commas in their names
Description
This extension provides a keyboard friendly way to open the select Finder items with an arbitrary application. After selecting some items in Finder, files or folders, you can invoke the command "Open Selection With…" and be presented with a filterable list of applications to open your selection with.
This is better solution for my previous script-command.
Type of change
Screencast
raycast-extension-open-finder-selection-with.mp4
Checklist
512x512