Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Open With App #147

Merged
merged 8 commits into from
Oct 25, 2021
Merged

New extension: Open With App #147

merged 8 commits into from
Oct 25, 2021

Conversation

fturcheti
Copy link
Contributor

@fturcheti fturcheti commented Oct 20, 2021

Description

This extension provides a keyboard friendly way to open the select Finder items with an arbitrary application. After selecting some items in Finder, files or folders, you can invoke the command "Open Selection With…" and be presented with a filterable list of applications to open your selection with.

This is better solution for my previous script-command.

Type of change

  • New extension

Screencast

raycast-extension-open-finder-selection-with.mp4

Checklist

FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Oct 20, 2021
@PitNikola PitNikola added the new extension Label for PRs with new extensions label Oct 20, 2021
@mattisssa mattisssa self-requested a review October 21, 2021 09:41
@mattisssa mattisssa self-assigned this Oct 21, 2021
Copy link
Contributor

@mattisssa mattisssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution!

Everything looks great, but please use .png icon 512x512 size for the extension as it described in the Guidelines

extensions/open-finder-selection-with/package.json Outdated Show resolved Hide resolved
@fturcheti
Copy link
Contributor Author

Hey @mattisssa! Thanks for the feedback. Yeah, I'll provide another icon. But I have two questions:

  1. Is it ok to use the Finder icon in this situation or I'll have to come up with something else?
  2. And what about the name of the extension? I think it doesn't fit exactly the guidelines, but it seems to be a good choice for this specific situation.

@mattisssa
Copy link
Contributor

@fturcheti

  1. yes, I think it's fine 👍
  2. I've updated my comments about naming, check them out, I think proposed ones is alright

@fturcheti fturcheti changed the title New extension: Open Finder Selection With New extension: Open With App Oct 22, 2021
@fturcheti
Copy link
Contributor Author

fturcheti commented Oct 22, 2021

@mattisssa I fixed the icon and updated the names according to your suggestions.

Edit: I was reviewing this and I found a "Open With…" command in Raycast. So wouldn't it be better to keep the ellipsis at the end of the command name?

Screen Shot 2021-10-22 at 10 19 01

The ellipsis is common UI element that indicates that you'll have another step in the process, so after hitting "Open With…" you'll have to make another selection before effectively opening something. Without the ellipsis, and with the Finder subtitle, it seems that you'll "Open With Finder":

Screen Shot 2021-10-22 at 10 53 39

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 💪

@fturcheti fturcheti marked this pull request as draft October 22, 2021 13:36
@mattisssa
Copy link
Contributor

The ellipsis is common UI element that indicates that you'll have another step in the process, so after hitting "Open With…" you'll have to make another selection before effectively opening something. Without the ellipsis, and with the Finder subtitle, it seems that you'll "Open With Finder":

@fturcheti yes, you are right, let's keep it like this "Open With…" 👍

- Cleaner getFinderSelection logic
- showHUD with warning when invoking the command with nothing selected in Finder
@fturcheti fturcheti marked this pull request as ready for review October 23, 2021 20:09
@fturcheti
Copy link
Contributor Author

yes, you are right, let's keep it like this "Open With…"

Thanks for the review, @mattisssa. I reverted this naming change, did a small code cleanup, improving the getFinderSelection logic, and updated the extension icon following the template provided in the extensions documentation.

Now we're ready to launch!

Copy link
Contributor

@mattisssa mattisssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 👍
Let's bring it to the Store now.

@mattisssa mattisssa merged commit 2312ea9 into raycast:main Oct 25, 2021
FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Nov 24, 2021
FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Nov 24, 2021
* New extension: Open Finder Selection With…

* Cleaner call for applescript execution

* Fix icon and names to better fit the extension guidelines

* Open With App: New icon

* Open With App: Revert command name change

* Open With App: Code cleanup

- Cleaner getFinderSelection logic
- showHUD with warning when invoking the command with nothing selected in Finder

* Open With App: Bug fix for files with commas in their names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants