Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use built-in icons for AWS extension #2431

Merged
merged 4 commits into from Aug 2, 2022
Merged

Use built-in icons for AWS extension #2431

merged 4 commits into from Aug 2, 2022

Conversation

JonathanWbn
Copy link
Contributor

@JonathanWbn JonathanWbn commented Jul 30, 2022 •
edited

Description

  • introduce the usage of built-in icons instead of imported icons for the "Codepipelines" extension
  • add an icon to list items of "Cloudformation Stacks"
  • add fallback to creation date to list items of "Cloudformation Stacks"
  • update "@raycast/api" dependency

Screenshots

CodePipelines Before

Screenshot 2022-07-30 at 13 54 45

CodePipelines After

Screenshot 2022-07-30 at 13 53 18

CloudFormation Stacks Before

Screenshot 2022-07-30 at 13 57 19

CloudFormation Stacks After

Screenshot 2022-07-30 at 13 58 05

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements OP is contributor The OP of the PR is a contributor of the extension labels Jul 30, 2022
@raycastbot
Copy link
Collaborator

raycastbot commented Jul 30, 2022 •
edited

Thank you for your contribution! 🎉

🔔 @victor-falcon @Hodglim @gebeto @momme-rtf @duboiss @hexpl0it you might want to have a look.

@JonathanWbn JonathanWbn changed the title Chore/icons Use built-in icons for AWS extension Jul 30, 2022
gebeto
gebeto approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@gebeto gebeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

pernielsentikaer
pernielsentikaer requested changes Aug 1, 2022
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JonathanWbn 👋

Thanks for the update, could you also add an entry in the changelog about this? 🔥

@pernielsentikaer
Copy link
Collaborator

Can you also check this @victor-falcon 🔥

@victor-falcon
Copy link
Contributor

For me, it's ok :), good job 🎉

@mattisssa mattisssa merged commit 4a1e82e into raycast:main Aug 2, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/Falcon/aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebeto gebeto gebeto approved these changes

@mattisssa mattisssa mattisssa approved these changes

@pernielsentikaer pernielsentikaer Awaiting requested review from pernielsentikaer

Assignees
No one assigned
Labels
extension fix / improvement Label for PRs with extension's fix improvements OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@JonathanWbn @raycastbot @pernielsentikaer @victor-falcon @gebeto @mattisssa