Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative tests abusing the consumer protocol #53

Closed
5 tasks
nikomatsakis opened this issue Feb 16, 2016 · 0 comments
Closed
5 tasks

Negative tests abusing the consumer protocol #53

nikomatsakis opened this issue Feb 16, 2016 · 0 comments

Comments

@nikomatsakis
Copy link
Member

To test unsafe consumers like collect, we need some negative tests of evil producers that fail to uphold their end of the bargain in various ways; we would want to be sure that the collect consumer doesn't fail under those cases.

Here are some ideas:

  • fail to produce correct number of items
  • produce too many items
  • abuse consumer protocol by never calling complete
  • abuse consumer protocol by leaking calling
  • not sure what else
nikomatsakis added a commit that referenced this issue Mar 16, 2017
@nikomatsakis
add test that drives the collect-consumer, producing too many values
6c9efe9 
`CollectConsumer` uses unsafe code but is not intended to "trust"
the producers, which are not generally unsafe, so it should be
ready for anything.

cc #53
@nikomatsakis nikomatsakis mentioned this issue Mar 16, 2017
Merged
nikomatsakis added a commit that referenced this issue Mar 16, 2017
@nikomatsakis
add test that drives the collect-consumer, producing too many values
abdc555 
`CollectConsumer` uses unsafe code but is not intended to "trust"
the producers, which are not generally unsafe, so it should be
ready for anything.

cc #53
@gaurikholkar-zz gaurikholkar-zz mentioned this issue Mar 19, 2017
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikomatsakis