[models] Load bone names from IQM file if available #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PencilAmazing
changed the title
raysan5
reviewed
Jan 23, 2023
|
@PencilAmazing Thanks for the improvement, just added some reviews. |
|
@PencilAmazing Thank you very much for the review! :) |
|
@raysan5 Thanks for the quick merge! |
futureapricot
pushed a commit
to futureapricot/raylib
that referenced
this pull request
Oct 4, 2023
* Load bone names from IQM file if available * Formatting and default bone name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply checks if joints were loaded in with animations file, and copies string data to name.
One issue is that maybe we should be using
strcpy_sinstead of raw memcpy?Fixes #2863