Fixed broken build.zig files. #3045
Conversation
…as of commit, latest is 0.10.1)
|
@Gamer-Kold Thanks for the review, actually it was reviewed last week I think... Yes, the zig build script is community maintained, feel free to add a note if you think it will be helpful for other users. |
|
latest raylib should be built with latest zig master branch. if you are using zig 0.10.0 use older raylib tagged version please. @raysan5 can we revert this please? examples build.zig wasn't touched (it's still master). and overall zig is moving forward to package manager, i'm using raylib in my project as is with zig package manager. @Gamer-Kold look at previous zig related PRs. zig 0.10.0 does have some bugs with C ABI, this was the cause i've updated raylib to zig latest master (0.11.0-dev). |
|
Makes sense. It didn't work on my machine with master; but if it's working on most other people's machines then I have no reason to hold back the revert. Not when I can keep a custom build file anyway. As an aside, I thought it was using a deprecated version of the system; a note in the build script stating which version it has been tested with (as said previously) would really be nice. |
|
@Gamer-Kold yeah. i think we should leave a note with specific zig version |
|
I'll try, I'll also revert the pull request since it seems thay hasn't happened yet. |
…mpiler (as of commit, latest is 0.10.1) (raysan5#3045)" This reverts commit de748df so that zig build script works with master branch of zig.
…e to all of them stating version of zig they were using (#3060) * Revert "Fixed broken build.zig files. Now works with latest stable compiler (as of commit, latest is 0.10.1) (#3045)" This reverts commit de748df so that zig build script works with master branch of zig. * Added a note to build.zig files that denotes what version of zig they have been tested with. * Standardised the note in the build.zig files
…as of commit, latest is 0.10.1) (raysan5#3045) Co-authored-by: Talha Qamar <qamartalha@proton.me>
…e to all of them stating version of zig they were using (raysan5#3060) * Revert "Fixed broken build.zig files. Now works with latest stable compiler (as of commit, latest is 0.10.1) (raysan5#3045)" This reverts commit de748df so that zig build script works with master branch of zig. * Added a note to build.zig files that denotes what version of zig they have been tested with. * Standardised the note in the build.zig files
I noticed the build.zig file wasn't working with the latest zig compiler. So I went ahead and fixed it. It went ahead and built fine on my linux machine, and I used the resulting library to compile the basic example, so I don't think there were any hidden errors.
(Small side note, is the zig build script community maintained? I'd want to add a notice to the build file itself if that was the case.)