Added UBSAN complaint fix to rLoadTexture #1891 #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that there is an error, |
|
Ah, missed that. I just recompute the offset from data on every iteration, |
|
@Codom did you add the chnage? I can't see it. |
|
It should be here: f0e7511 |
|
@Codom I'm merging it but I'm reviewing this implementation, I'll take the variable definition out of the loop and also the conditional check. |
futureapricot
pushed a commit
to futureapricot/raylib
that referenced
this pull request
Oct 4, 2023
futureapricot
pushed a commit
to futureapricot/raylib
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to trigger the ubsan by simply calling
LoadRenderTexture(1280, 720);from zig. Looking at recent PR's and issues it seems like this issue has already been mitigated elsewhere, but still exists in the codepath for LoadRenderTexture.All I did was apply a similar fix (as seen in 30a9a24) for #1891 to the rLoadTextures function. This seems to fix the issue.