Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for passing orgKey as query param, require use of razee-org-key header #1332

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

carrolp
Copy link
Contributor

@carrolp carrolp commented Jun 20, 2023

Remove support for passing orgKey as query param, require use of razee-org-key header.

This is a breaking change to the registerCluster and enableRegistrationUrl response. Previously the url in the response could be used by itself, e.g. kubectl apply -f [url]. After this change, this will no longer work as the orgKey will not be part of url and the expected razee-org-key header cannot be passed by kubectl.

Before updating to this version of Razeedash-api, any consumer of the registerCluster or enableRegistrationUrl apis must be updated to support the headers response.

@carrolp carrolp changed the title Register script query 20230620 Remove support for passing orgKey as query param, require use of razee-org-key header Jun 20, 2023
@carrolp carrolp marked this pull request as ready for review June 23, 2023 18:14
@carrolp carrolp merged commit 1b410a6 into master Jun 23, 2023
2 checks passed
@carrolp carrolp deleted the register-script-query-20230620 branch June 23, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants