Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Trims the whitespace from the derived bundleVersion to fix issue #487 #488

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Trims the whitespace from the derived bundleVersion to fix issue #487 #488

merged 1 commit into from
Oct 2, 2020

Conversation

byaruhaf
Copy link
Contributor

Trims the whitespace from the derived bundleVersion to fix issue #487, and also output the build number in the build report.

Signed-off-by: Franklin Byaruhanga byaruhaf@appbantu.com

… the build number in the build report.

Signed-off-by: Franklin Byaruhanga <byaruhaf@appbantu.com>
Copy link
Contributor

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (these flaky tests are annoying!)

@0xTim
Copy link
Contributor

0xTim commented Oct 1, 2020

Ooh we're green! Will merge once @sammyd gives a thumbs up

Copy link
Collaborator

@sammyd sammyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@0xTim 0xTim merged commit d6c8913 into razeware:development Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell script to update the build number (CFBundleVersion) of the info.plist in the build folder fail's
3 participants