Gui Fixes, status bar, plot colors #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rbaltrusch
commented
Jun 22, 2024
rbaltrusch
commented
- Add status label (running 1/10, finished running...)
- Add copied label
- For boolean arguments, remove "True" from cli arg in gui
- Fix: current plot colour should be a different line than other plots
- Fix: plot max should be max of all lines, not just current line
- Fix: cannot simply call bach_generator -h
- Fix: doesnt close properly
- Fix: KeyError: view config
- Fix: Gui not closing correctly
- Replace matplotlib.figure.Figure() with plt.figure() ...
This was failing due to the gui opening incorrectly and failing.
Boolean CLI arguments were causing a problem where their state was appended to their CLI arg, e.g. --save True instead of --save, which was causing the program command generated to be invalid.
The gui was not correctly closing and kept running the ML command even after pressing the close button
The gui was not correctly opening due to an outdated matplotlib api usage.
This avoids the current plot truncating the view for plots with higher points.
rbaltrusch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.