-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .clang-format #22
Open
martinfelis
wants to merge
54
commits into
rbdl:master
Choose a base branch
from
martinfelis:clang-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able as it will likely go through a few changes.
….qdot_size. Thanks to SongyanXIN for reporting!
…use user provided model file instead of hardcoded file name
…eParameters, not the one sided version. Thanks to Anna Lena there is now a hard test case that has been added.
…Parameters: previously only active muscles were fit which is a problem if the passive element is too stiff. Now everything gets fitted.
…cific issues still
…te axes. For this Model::X_J was removed. All joints - especially CustomJoints - have to compute Model::X_lambda directly.
…ter compatibility with Eigen)
…hey required a csv file that is not copied over until the install phase. Now the data is embedded as an array in the test file: no csv file is required
…rical (quaternion) joints would result in wrong dimensions
- Should enable tracking of performance regressions. - Existing dynamics and contacts benchmarks supported (not yet: kinematics benchmarks)
Benchmark addon allows printing results as json file.
Travis CI will build RBDL once with SimpleMath support and once with Eigen3. The benchmark addon is included to validate performance on Travis CI infrastructure. The builds use either GCC or clang to compile. The pre_script performs configuration of the build via cmake defines. The test script itself 1) compiles RBDL with "-Wall -Wpedantic -Wextra -Werror", 2) runs the unit tests, and 3) runs the benchmark suite. As part of the work, all warnings for RBDLi, benchmark and unittests were fixed. Additionally the cmake infrastructure required small adaptions to build everyting with c++11 support, i.e., rbdk, tests, benchmarks.
Changed three files in order to ensure executability also for Lua 5.3 Merged as it is only a minor change in the addon.
@martinfelis I have some questions concerning this:
|
I would just reformat the whole code base and also add checks whether the format is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test the style settings in this PR.
Should be used to automatically format the whole code base of RBDL.
Note: matrices need special guards to keep formatting (see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code)