Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .clang-format #22

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Conversation

martinfelis
Copy link
Collaborator

Please test the style settings in this PR.

Should be used to automatically format the whole code base of RBDL.

Note: matrices need special guards to keep formatting (see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code)

martinfelis and others added 30 commits May 3, 2018 11:41
…able

as it will likely go through a few changes.
….qdot_size. Thanks to SongyanXIN for reporting!
…use user provided model file instead of hardcoded file name
…eParameters, not the one sided version. Thanks to Anna Lena there is now a hard test case that has been added.
…Parameters: previously only active muscles were fit which is a problem if the passive element is too stiff. Now everything gets fitted.
martinfelis and others added 24 commits December 8, 2018 23:42
…te axes.

For this Model::X_J was removed. All joints - especially CustomJoints -
have to compute Model::X_lambda directly.
…hey required a csv file that is not copied over until the install phase. Now the data is embedded as an array in the test file: no csv file is required
…rical (quaternion) joints would result in wrong dimensions
- Should enable tracking of performance regressions.
- Existing dynamics and contacts benchmarks supported (not yet: kinematics benchmarks)
Benchmark addon allows printing results as json file.
Travis CI will build RBDL once with SimpleMath support and once with
Eigen3. The benchmark addon is included to validate performance on
Travis CI infrastructure. The builds use either GCC or clang to compile.
The pre_script performs configuration of the build via cmake defines.
The test script itself 1) compiles RBDL with "-Wall -Wpedantic -Wextra
-Werror", 2) runs the unit tests, and 3) runs the benchmark suite.

As part of the work, all warnings for RBDLi, benchmark and unittests were fixed.
Additionally the cmake infrastructure required small adaptions to build
everyting with c++11 support, i.e., rbdk, tests, benchmarks.
Changed three files in order to ensure executability also for Lua 5.3

Merged as it is only a minor change in the addon.
@mkudruss
Copy link
Member

@martinfelis I have some questions concerning this:

  • What strategy do you prefer?
    • Reformat the whole code base
    • Add githook to format current changes
  • Shall the format guards be part of this PR or handled by each future PR?

@martinfelis
Copy link
Collaborator Author

I would just reformat the whole code base and also add checks whether the format is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants