-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark addon allows printing results as json file. #7
Conversation
martinfelis
commented
Mar 29, 2020
- Should enable tracking of performance regressions.
- Existing dynamics and contacts benchmarks supported (not yet: kinematics benchmarks)
- Should enable tracking of performance regressions. - Existing dynamics and contacts benchmarks supported (not yet: kinematics benchmarks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Martin,
thanks for the contributions. Json output will be very helpful in the future for performance regression analysis. Here are some general comments on your changes:
- CMakeLists.txt <- No comments.
- SampleData.h <- No problem with the additions but the file needs some reformatting to pass RBDL style guide. Spacing around ctor, dtor, etc. would make it better readable. Consider doing the changes for this file.
- benchmarks.cc <- Code is slightly refactored. The execution of benchmarks should be more generalized in the future for better maintainability. Same holds true for the manual composition of the json output.
- SimpleMath.h <- Nice that you added the eigen3 operators for simple math. Indeed helpful. Consider adding some "consts" when for read only variables.
- rbdl_version.cc <- No problem with the code but needs some reformatting to pass RBDL style guide. This is also true for your changes. Consider making the changes for the whole file.
@paulmanns will you perform the review or can we close the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.