Improve Fish compatiblity with subshells #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
reviewed
Nov 29, 2017
| @@ -86,8 +86,10 @@ mkdir -p "${RBENV_ROOT}/"{shims,versions} | |||
|
|
|||
| case "$shell" in | |||
| fish ) | |||
| echo "set -gx PATH '${RBENV_ROOT}/shims' \$PATH" | |||
| echo "set -gx RBENV_SHELL $shell" | |||
| echo "if status --is-login" | |||
There was a problem hiding this comment.
We already do this check when giving people instructions how to set up rbenv init in their fish initialization file:
Line 73 in 2d7cefe
Do you think that is-interactive check isn't enough? What does is-login achieve?
Khongjhon
approved these changes
Apr 15, 2018
|
Closing as wontfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases compatibility with subshells. Other shells should do this too, but let's start with fish.