rbenv-prefix: do not silence rbenv-which for system version #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but I think one error message is enough! This is a rare case anyway. |
I think the main issue here is that it also silences all of |
Ah I see. That's a fair point. I'm willing to accept a PR that doesn't break the test suite. |
This suppressed any output when using RBENV_DEBUG=1 and does not really hurt to have in the unlikely case that it should fail; you would get two error messages now: rbenv: ruby: command not found rbenv: system version not found in PATH
blueyed
force-pushed
the
prefix-no-devnull
branch
from
a1215fb
to
806f3f6
Compare
|
Thanks, tests should be passing now. |
jasonkarns
added a commit
to nodenv/nodenv
that referenced
this pull request
Nov 8, 2018
Includes: rbenv/rbenv#1098 rbenv/rbenv#1093 rbenv/rbenv#1083 rbenv/rbenv#1069 rbenv/rbenv#981 rbenv/rbenv#1013 rbenv/rbenv#968 rbenv/rbenv#959 rbenv/rbenv#982 rbenv/rbenv#1002 rbenv/rbenv#1003 rbenv/rbenv#1024 rbenv/rbenv#1034 rbenv/rbenv#1009 rbenv/rbenv#1011 Merge remote-tracking branch 'rbenv/master' into rbenv-update * rbenv/master: rbenv-prefix: do not silence rbenv-which for system version rbenv-which: change PATH only for the "command -v" lookup make rbenv init more visible in the readme (#1092) Remove ableist language Link to rbenv-installer Update instructions for $PATH change in README Fix rbenv/rbenv#1065 Add tests for shell integration Better error message for `rbenv shell` Fix some issues reported by shellcheck Quote directory name in variable assignment test/which.bats: do not export PATH Fixed `rbenv init -` output to work w/ no args and bash's `set -u`. Fix URL fragment target Fixed support of build env vars for dynamic bash extension configure script properly escapes commas in cflags rbenv 1.1.1 Clarify Homebrew/git install guidance rbenv-version-file: ensure that the version file is a file Don't unset CDPATH Enforce absolute RBENV_DIR partly resolve #759 Fix pyenv -> rbenv typo Fix fish subcommand completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suppressed any output when using RBENV_DEBUG=1 and does not really
hurt to have in the unlikely case that it should fail; you would get
two error messages now:
rbenv: ruby: command not found
rbenv: system version not found in PATH