Skip to content

Commit

Permalink
Don’t look for homebrew openssl
Browse files Browse the repository at this point in the history
  • Loading branch information
@gfguthrie
gfguthrie committed Nov 8, 2019
1 parent 9383de3 commit 9d96a6b
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions bin/ruby-build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1020,18 +1020,7 @@ has_broken_mac_openssl() {
is_mac || return 1
local openssl_version="$(/usr/bin/openssl version 2>/dev/null || true)"
[[ $openssl_version = "OpenSSL 0.9.8"?* || $openssl_version = "LibreSSL"* ]] &&
[[ "$RUBY_CONFIGURE_OPTS" != *--with-openssl-dir=* ]] &&
! use_homebrew_openssl
}

use_homebrew_openssl() {
local ssldir="$(brew --prefix openssl@1.1 2>/dev/null || true)"
if [ -d "$ssldir" ]; then
echo "ruby-build: using openssl from homebrew"
package_option ruby configure --with-openssl-dir="$ssldir"
else
return 1
fi
[[ "$RUBY_CONFIGURE_OPTS" != *--with-openssl-dir=* ]]
}

build_package_mac_openssl() {
Expand Down

1 comment on commit 9d96a6b

@wadkar
Copy link

@wadkar wadkar commented on 9d96a6b Mar 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is few months old, but @gfguthrie can you please tell us why ruby-build should not look/use homebrew's openssl?

The wiki suggests to install openssl as recommended build environment (and openssl gets picked up by python-build as well). A later commit reintroduces the use_homebrew_openssl function but it never gets called.

Should we update the docs to tell our users that ruby-build will be installing it's own openssl and not going to trust/use homebrew's openssl?

How does this differ from readline, which gets picked up by ruby-build?

/ping @mislav @hsbt @eregon

Please sign in to comment.