Skip to content

Commit

Permalink
Build a shared openssl to link to Ruby as a stopgap to fix build issu…
Browse files Browse the repository at this point in the history 
…es some people are having, pending understanding why static linking isn't working.
  • Loading branch information
@jeremy
jeremy committed Feb 25, 2013
1 parent c59f4a7 commit fee1e49
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bin/ruby-build
View file
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,8 @@ build_package_mac_openssl() {
export KERNEL_BITS="64"
OPENSSL_CONFIGURE="${OPENSSL_CONFIGURE:-./config}"

# Compile with zlib, no kerberos, and do a static build.
package_option openssl configure --openssldir="$OPENSSLDIR" zlib no-krb5 no-shared
# Compile a shared lib with zlib dynamically linked, no kerberos.
package_option openssl configure --openssldir="$OPENSSLDIR" zlib-dynamic no-krb5 shared

# Default MAKE_OPTS are -j 2 which can confuse the build. Thankfully, make
# gives precedence to the last -j option, so we can override that.
Expand Down

10 comments on commit fee1e49

@sferik
Copy link
Contributor

@sferik sferik commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth pushing another tag/release just for this change or do you want to wait until we understand the problem better? Personally, I’d like to understand the root cause of the problem before we release this change.

@kevinSuttle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sferik
Copy link
Contributor

@sferik sferik commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinSuttle Are you 👍 a release or waiting until we understand the problem better and fix static linking? I’d still like to try to understand why this was broken for you but not for me.

@kevinSuttle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sferik Both, but mainly waiting until we understand the problem better and fix static linking. Obviously this is a bigger underlying problem.

@jeremy
Copy link
Member Author

@jeremy jeremy commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to understand the root cause, too, but static linking isn't critical either, so I think it's worth releasing as a stopgap.

@sferik
Copy link
Contributor

@sferik sferik commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremy Okay. I won’t have time to push a release until later today or tomorrow. Feel free to do it yourself if you want it before then.

Has any of this made you reconsider your decision to remove homebrew openssl support from #273? Then we could credibly go with option number 2 in #316 (delegate certificate management to curl-ca-bundle). It adds a bit of complexity but could prevent bigger headaches in the future, after a certificate is revoked.

@jeremy
Copy link
Member Author

@jeremy jeremy commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like homebrew integration, too, but it wasn't worth complicating our first effort.

curl-ca-bundle doesn't install a default OPENSSLDIR/cert.pem so no luck there.

@wfarr
Copy link

@wfarr wfarr commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sferik have you tried removing homebrew OpenSSL and using the latest tagged release? It fails to compile quite consistently without this change.

@sferik
Copy link
Contributor

@sferik sferik commented on fee1e49 Feb 25, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wfarr Yes. I just tried that and it still works for me.

@sferik
Copy link
Contributor

@sferik sferik commented on fee1e49 Feb 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I just tagged v20130226 and submitted a pull requested to homebrew: Homebrew/legacy-homebrew#18100.

Please sign in to comment.