Fix tests on macOS #1254
Merged
Fix tests on macOS #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the tests to run on FreeBSD, the bash executable needs to be available in PATH. The test_helper PATH was modified by 49a9471 and f70d958 in order to be sure that bash is in PATH on FreeBSD. (The default location for packages on FreeBSD is /usr/local/bin, and since bash isn't provided by FreeBSD itself, that means /usr/local/bin is the most common, if not only, location to find bash on FreeBSD.) However, adding /usr/local/bin to PATH means that homebrew-managed packages on macOS are now in PATH for the test suite. This is especially important due to packages like readline. Since ruby-build prefers homebrew readline when available, this makes the tests fail on macOS (because the tests are written assuming no readline configuration.) While the tests could stub brew in all cases, to ensure the readline package is ignored by the tests, it seems more prudent to revert the PATH to be as minimal as possible, and to only include /usr/local/bin by precisely the OS that depends on it.
|
Great! I always switch |
|
Thank you @jasonkarns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056
PR #1038, specifically https://github.com/rbenv/ruby-build/pull/1038/files#diff-2b060f35496217f5f6b474e5552c11e2L6
broke the test suite on macOS.
This is because including
/usr/local/bininPATHmakeshomebrew packages available to the tests, in particular readline.
Since ruby-build will prefer homebrew readline if available, making it
available in the tests will break any assertions that assume it won't
be available.
This PR also enables the test suite to run on macOS on Travis to prevent
regressions. The enabling of travis is the first commit, such that the
build can be seen to fail before the fix in the second commit.