Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rubinius #863

Closed
wants to merge 2 commits into from
Closed

Remove Rubinius #863

wants to merge 2 commits into from

Conversation

sferik
Copy link
Contributor

@sferik sferik commented Jan 1, 2016

No description provided.

@sferik sferik mentioned this pull request Jan 1, 2016
3 tasks
@hsbt
Copy link
Member

hsbt commented Jan 1, 2016

require_llvm and locate_llvm should be removed too.

@jasonkarns jasonkarns mentioned this pull request Jan 15, 2016
@jasonkarns
Copy link
Member

Is it really prudent to remove the functions from ruby-build itself? One key feature of ruby-build is that the definition lookup path can be configured, so one can provide their own custom definitions. Even if the rubinius definitions are removed, removing the rubinius-specific functions would break any custom definitions that rely on them. This would be a pretty big compatibility-breaking change. Might there be value in keeping the rubinius functions a while longer? Or perhaps a deprecation phase would be beneficial to warn users that their definitions would break soon (with whatever release would actually remove the functions, assuming the rubinius removal actually moves forward).

@peteygao
Copy link

peteygao commented Mar 3, 2016

What is the reasoning for dropping Rubinius support in ruby-build? I actively use Rubinius and have in the past week installed Rubinius 3.16 via ruby-build. In fact I would have installed the latest version 3.19 if #911 was already merged.

@hsbt
Copy link
Member

hsbt commented Jan 11, 2017

I will close this.

We can passively maintain rubinius. ref. #1035

@hsbt hsbt closed this Jan 11, 2017
@hsbt hsbt deleted the remove-rubinius branch January 11, 2017 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants