Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildin UI custom shader problems #566

Open
WyrdanGames opened this issue May 28, 2023 · 0 comments
Open

Buildin UI custom shader problems #566

WyrdanGames opened this issue May 28, 2023 · 0 comments

Comments

@WyrdanGames
Copy link
Contributor

WyrdanGames commented May 28, 2023

UI/UI.cpp
void UI::Render(VertexBuffer* buffer, const ea::vector<UIBatch>& batches, unsigned batchStart, unsigned batchEnd)
seems to use the first batch.customMaterial_ global to all following UI-Batches

I have changed the HelloWorld.cpp to reproduce the issue, also added 2 techniques/materials/shader for testing.

[picmento.de/rbfxfiles/HelloWorld.zip]

Erlangist added a commit to Erlangist/rbfx that referenced this issue Jun 6, 2023
eugeneko added a commit that referenced this issue Jun 11, 2023
In issue #566 all consecutive custom materials in UI was treated as one.
That's no longer the case.

Probably some more optimizations can be added, if two different UI
materials have exactly the same parameters

---------

Co-authored-by: Eugene Kozlov <nekoeuge@gmail.com>
eugeneko added a commit that referenced this issue Jun 12, 2023
In issue #566 all consecutive custom materials in UI was treated as one.
That's no longer the case.

Probably some more optimizations can be added, if two different UI
materials have exactly the same parameters

---------

Co-authored-by: Eugene Kozlov <nekoeuge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant