Solves the issue #566 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UI was treated as one
|
@Erlangist can you check if new version of your fix branch still works for you? It seems more correct. |
|
Yes, it works as intended |
eugeneko
approved these changes
Jun 11, 2023
Source/Urho3D/UI/UI.cpp
Outdated
| // Assuming that custom batch material have different parameters that | ||
| // the material in previous batch. Further optimizations are possible. | ||
| // Solves the issue #566 | ||
| if (drawQueue->BeginShaderParameterGroup(SP_MATERIAL, batch.customMaterial_)) |
There was a problem hiding this comment.
The idea is good but I don't think this is correct implementation.
Second parameter indicates wherther the attributes have changed, it's weird to just pass pointer there.
You should track current material (null by default) and pass batch.customMaterial_ != currentMaterial instead.
Can you check if that will work for you?
eugeneko
added a commit
that referenced
this pull request
Jun 12, 2023
In issue #566 all consecutive custom materials in UI was treated as one. That's no longer the case. Probably some more optimizations can be added, if two different UI materials have exactly the same parameters --------- Co-authored-by: Eugene Kozlov <nekoeuge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #566 all consecutive custom materials in UI was treated as one. That's no longer the case.
Probably some more optimizations can be added, if two different UI materials have exactly the same parameters