Editor --plugin command line argument #602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokups
reviewed
Sep 3, 2023
| @@ -363,7 +363,7 @@ ModuleType DynamicModule::ReadModuleInformation(Context* context, const ea::stri | |||
| return MODULE_INVALID; | |||
|
|
|||
| auto* nt = reinterpret_cast<PIMAGE_NT_HEADERS>(data.data() + dos->e_lfanew); | |||
| if (!IsValidPtr(data, dos) || nt->OptionalHeader.Magic != IMAGE_NT_OPTIONAL_HDR_MAGIC) | |||
| if (!IsValidPtr(data, dos))// || nt->OptionalHeader.Magic != IMAGE_NT_OPTIONAL_HDR64_MAGIC) | |||
There was a problem hiding this comment.
But it's wrong?
|
User will definitely want to have more than one plugin. IMO this should better be in a shape of adding multiple additional plugin search paths. All plugins can be enabled by default if plugin state is not configured in the editor (not sure how it works now). |
Is it absolute must? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editor now accepts --plugin command as an argument.
The plugin name treated as an "implicit plugin", i.e it is injected into project even if it is not mentioned in the project configuration.
nt->OptionalHeader.Magic is ignored because netstandard2.0 assembly seems to be marked as 32-bit even if built for x64 platform and it works just fine.