-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BJ-921: Add chargebacks and adjustment payment status #257
Conversation
fetchOne(query, (rs, i) -> ImmutableMap.<String, String>builder() | ||
.put("merchant_id", rs.getString("merchant_id")) | ||
.put("shop_id", rs.getString("shop_id")) | ||
.put("currency_code", rs.getString("currency_code")) | ||
.put("funds_returned", rs.getString("funds_returned")) | ||
.build()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
может лямбду все-таки в метод?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно) Но я в надежде на замену всего этого в виде репортера)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Понял. Принял)))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ща добавляю
ImmutableMap.<String, String>builder() | ||
.put("merchant_id", merchantId) | ||
.put("shop_id", shopId) | ||
.put("currency_code", currencyCode) | ||
.put("funds_returned", "0") | ||
.build() | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и вот это
@D-Baykov в рамках исправлений по ревью еще переработал запросы, убрал у всех группировки, они были не нужны. Должно дать буста. В результате опциональность перевел в сам запрос и под единный row mapper. |
https://rbkmoney.atlassian.net/browse/BJ-921