Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install fails on OSX #102

Closed
tessus opened this issue Jun 10, 2016 · 4 comments · Fixed by #103
Closed

make install fails on OSX #102

tessus opened this issue Jun 10, 2016 · 4 comments · Fixed by #103

Comments

@tessus
Copy link
Contributor

tessus commented Jun 10, 2016

$ sudo make install
install -d sslscan /usr/bin/sslscan;
install: sslscan exists but is not a directory
make: *** [install] Error 71

It worked perfectly without the -d option, but 6c5f8b1 broke it for me.

@rbsec
Copy link
Owner

rbsec commented Jun 13, 2016

The -d flag was added by @dsXLII in #95 to fix the installer when the folders didn't exist.

sslscan has always been developed and tested on Linux - I don't use OSX (and to be honest, I very rarely use make install with sslscan), so I'm not in a position to test whether PRs like #95 will break other stuff on OSX.

If one of you can find a solution that works in both cases (file exists and folders don't) then please submit a PR with it.

@tessus
Copy link
Contributor Author

tessus commented Jun 13, 2016

@dsXLII introduced a bug. he probably thought that BSD install works the same as on Linux.
Please check the man page for install on BSD / OSX.
install -d [-v] [-g group] [-m mode] [-o owner] directory ...

I'll submit a pull request shortly.

@dsXLII
Copy link
Contributor

dsXLII commented Jun 13, 2016

Hm. Worked for me, but maybe I was using a non-standard version of "install". (shrug) Mea culpa. I'll check it out later today - the Mac is at home and I'm not.

tessus added a commit to tessus/sslscan that referenced this issue Jun 13, 2016
@tessus
Copy link
Contributor Author

tessus commented Jun 13, 2016

@dsXLII no worries. making sure the directory exists, is a good practice anyway, but we have to change the code a bit.

rbsec added a commit that referenced this issue Jun 13, 2016
'install -d' only takes a directory as an argument, fix #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants