Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the underscore prefix of __bp_imported #123

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

FranklinYu
Copy link
Contributor

@FranklinYu FranklinYu commented Jan 20, 2022

This formally exposes it as part of the public API. RFC: @dimo414.

Fixes #122.

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@rcaloras rcaloras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @FranklinYu! Looks like there's a couple other places that use the original name:

[rcaloras:~/git/bash-preexec] master ± git grep __bp_imported
...
test/include-test.bats:  __bp_imported="defined"
test/include-test.bats:  unset __bp_imported

Can you also the test case for this in to use the new variable name?

bash-preexec.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bash-preexec.sh Outdated Show resolved Hide resolved
@FranklinYu
Copy link
Contributor Author

All of the suggestion above looks good to me, but apparently the test is currently broken. For example, the “include test” use __bp_preexec_and_precmd_install to decide whether bash-preexec is loaded, but this function isn’t there regardless. Shall I start another PR to fix the test before moving forward with this one?

@FranklinYu
Copy link
Contributor Author

I’m glad that the CI is working, and it caught a bug. I’ll fix it before marking this as “ready for review”.

Variables were reanmed in 7fbc07f, but
it didn’t cover the test or ReadMe. This commit fixes that.
@FranklinYu FranklinYu marked this pull request as ready for review January 27, 2022 08:26
@FranklinYu
Copy link
Contributor Author

I finally addressed all the comments. The history seems a bit messy; maybe consider merge by squashing the commits.

Copy link
Owner

@rcaloras rcaloras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

official way to detect whether bash-preexec is loaded
3 participants