Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove saving prior trap in PROMPT_COMMAND with subshell #60

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Remove saving prior trap in PROMPT_COMMAND with subshell #60

merged 1 commit into from
Oct 19, 2017

Commits on Oct 19, 2017

  1. Remove saving prior trap in PROMPT_COMMAND with subshell 

    - This was causing crashes in cases where users were doing:
  export PROMPT_COMMAND="history -a; $PROMPT_COMMAND;"

- Original description from contributor:
  $(trap -p DEBUG)" is launching a sub-shell, bash itself. So when people do
  "export PROMPT_COMMAND="history -a; $PROMPT_COMMAND;"", they export form the
  parent shell to subsequent sub-shells. And that creates the infinite loop,
  that eventually segfault bash.
    @rcaloras
    rcaloras committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    2d88f5e View commit details
    Browse the repository at this point in the history