Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove saving prior trap in PROMPT_COMMAND with subshell #60

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Remove saving prior trap in PROMPT_COMMAND with subshell #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions bash-preexec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,15 @@ __bp_install_after_session_init() {
precmd_functions+=(__bp_original_prompt_command)
fi

# Save anything already defined in our trap
__bp_trap_string="$(trap -p DEBUG)"

# Installation is finalized in PROMPT_COMMAND, which allows us to override the DEBUG
# trap. __bp_install sets PROMPT_COMMAND to its final value, so these are only
# invoked once.
# It's necessary to clear any existing DEBUG trap in order to set it from the install function.
# Using \n as it's the most univer delimiter of bash commands
PROMPT_COMMAND=$'\n__bp_trap_string="$(trap -p DEBUG)"\n trap DEBUG\n __bp_install\n'
# Using \n as it's the most universal delimiter of bash commands
PROMPT_COMMAND=$'\ntrap DEBUG\n__bp_install\n'
}

# Run our install so long as we're not delaying it.
Expand Down