Update bash-preexec.sh #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lguelorget
commented
Oct 24, 2017
lguelorget
commented
- Avoids infinite recursion with things like export PROMPT_COMMAND="history -a; $PROMPT_COMMAND"
- Preserve trap DEBUG again: revert Remove saving prior trap in PROMPT_COMMAND with subshell #60
- Avoids infinite recursion with things like export PROMPT_COMMAND="history -a; $PROMPT_COMMAND" - Preserve trap DEBUG again: revert rcaloras#60
jombooth
reviewed
Oct 25, 2017
bash-preexec.sh
Outdated
| @@ -83,10 +86,17 @@ __bp_interactive_mode() { | |||
| # This function is installed as part of the PROMPT_COMMAND. | |||
| # It will invoke any functions defined in the precmd_functions array. | |||
| __bp_precmd_invoke_cmd() { | |||
|
|
|||
| # Save the returned value from our last command | |||
There was a problem hiding this comment.
Since this is problem is quite unintuitive, I think putting a comment like
# Save the returned value from our last command. Note: this MUST be the
# first thing done in this function.
would help avoid it resurfacing in the future.
jombooth
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.