Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore DEBUG trap preservation #61

Closed
dimo414 opened this issue Oct 21, 2017 · 4 comments
Closed

Restore DEBUG trap preservation #61

dimo414 opened this issue Oct 21, 2017 · 4 comments

Comments

@dimo414
Copy link
Collaborator

dimo414 commented Oct 21, 2017

PR #60 regressed the fix to #39. We need to identify a new mechanism to capture traps that avoids the issues discussed there.

As I understand it this is only an issue for users who erroneously export their PROMPT_COMMAND at some point in their .bashrc, so if we can detect that case we could simply not preserve traps for those users.
@lguelorget
Copy link
Contributor

Gave it a go at: #62

@lguelorget
Copy link
Contributor

I believe I've addressed the regression in #62. Let me know if that works.

@rcaloras
Copy link
Owner

@lguelorget Thanks a lot for the PR! Much appreciated 👍 💯

@rcaloras
Copy link
Owner

Released 0.3.6 which has the fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rcaloras @dimo414 @lguelorget