Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using iTerm2 + shell integration won't save commands. #27

Closed
rcaloras opened this issue Mar 29, 2016 · 3 comments
Closed

Using iTerm2 + shell integration won't save commands. #27

rcaloras opened this issue Mar 29, 2016 · 3 comments

Comments

@rcaloras
Copy link
Owner

rcaloras commented Mar 29, 2016 •
edited
Loading

@tmccartan https://bashhub.com/u/tmccartan Spotted this since there's a conflict with bash-preexec and iTerm2 with shell integration.

Looks like both libraries try to make a play for the debug trap. I'm wondering if we can standardize to use one library and just queue up preexec functions from there.
This was referenced Mar 29, 2016
Open
Closed
@rcaloras rcaloras mentioned this issue Apr 18, 2016
Closed
@rcaloras
Copy link
Owner Author

rcaloras commented Apr 27, 2016 •
edited
Loading

@tmccartan Believe this should be fixed in the latest dev version of Bashhub. Could you try updating to it and see if it's saving properly?

$ bashhub update 1.0.2-dev

Let me know if it works. Thanks dude!

@tmccartan
Copy link

Works like a charm

🍔 🍟

@rcaloras
Copy link
Owner Author

rcaloras commented Apr 27, 2016 •
edited
Loading

Great! Addressed in 1.0.2-dev. I'll merge into master soon.

paysonwallach pushed a commit to paysonwallach/bashhub-client that referenced this issue Sep 6, 2020
@rcaloras
Updated to bash-preexec 0.3.0
19bec30 
- Fixes rcaloras#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcaloras @tmccartan