Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm option for periodic boundaries #92

Merged
merged 1 commit into from
Feb 19, 2024
Merged

rm option for periodic boundaries #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions xnemogcm/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
)


def compute_missing_metrics(
ds, all_scale_factors=all_scale_factors, time_varying=True, periodic=False
):
def compute_missing_metrics(ds, all_scale_factors=all_scale_factors, time_varying=True):
"""
Add all possible scale factors to the dataset.

Expand All @@ -33,7 +31,7 @@ def compute_missing_metrics(
If e3t_0 is not found (e.g. for nemo 3.6), it will raise a warning and use e3t_1d
(this will lead to wrong results if terrain-following coordinates are used).

May have some boundary issues.
May have some boundary issues, and only non-periodic boundaries are implemented.

Will add the metrics to the given dataset. To avoid this, use a ds.copy()

Expand Down
Loading