fix(#275): do not overwrite colorscheme highlights #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlights set by colorschemes are overwritten by `nvim-dap-ui` plugin
in the `require("dapui.config").highlights.lua:setup()` method.
Modified the method to set the defaults for highlight groups instead
of overwriting previously set highlights (typically by colorschemes).
Added a helper function to use the newer `nvim_get_hl` API function if
NeoVim's version is atleast 0.9.
|
Hey @rcarriga, |
|
LGTM, thanks for the PR! |
y1rn
added a commit
to y1rn/nvim-dap-ui
that referenced
this pull request
May 30, 2023
fix(highlights): preserve colorscheme settings (rcarriga#276)
|
@dasupradyumna Thank you! Just confirmed that the fix works! Thanks for fixing the issue I care a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Highlight groups set by colorschemes are overwritten by
nvim-dap-uiplugin in therequire("dapui.config").highlights.lua:setup()method, instead of just setting the fallback default highlight groups.More information can be found in #275 and #178.
Changes
nvim_get_hlAPI function if NeoVim's version is atleast 0.9.setup()method logic by moving the error checking (pcall) into the helper function.