Fix edit variables #355
Merged
Fix edit variables #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This worked for me on Windows 11 and Neovim 0.10.0. |
|
Thanks for the PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #349
As reported by the linked issue, editing variables shows an error, although it works as expected. The problem was that it wasn't capturing the first
pcallreturn value (aka success) to figure out whether thepcallworked or not, and then, yes, use its second return value (akaresult) to eventually handle the error.More info: http://www.lua.org/manual/5.1/manual.html#pdf-pcall