Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace tbl_flatten to flatten():totable() #359

Merged
merged 1 commit into from
May 20, 2024

Conversation

pablobfonseca
Copy link
Contributor

Deprecation warnings in v0.10 and v11 nightlies

vim.tbl_flatten is deprecated, use vim.iter(…):flatten():totable() instead. :help deprecated
Feature will be removed in Nvim 0.12

@rcarriga rcarriga merged commit 71bfe9b into rcarriga:master May 20, 2024
@rcarriga
Copy link
Owner

Thanks for the PR!

@busla
Copy link

busla commented May 20, 2024

This PR broke something.

image

My config (from nvim-kickstart)

    dapui.setup {
      -- Set icons to characters that are more likely to work in every terminal.
      --    Feel free to remove or use ones that you like more! :)
      --    Don't feel like these are good choices.
      icons = { expanded = '', collapsed = '', current_frame = '*' },
      controls = {
        icons = {
          pause = '',
          play = '',
          step_into = '',
          step_over = '',
          step_out = '',
          step_back = 'b',
          run_last = '▶▶',
          terminate = '',
          disconnect = '',
        },
      },
    }

@pablobfonseca
Copy link
Contributor Author

Hi @busla which version of neovim are you using? I'll try to reproduce it

@busla
Copy link

busla commented May 20, 2024

v0.9.5

@phdah
Copy link

phdah commented May 20, 2024

FYI: This was a breaking change from NVIM v0.9 , vim.iter() was implemented here which was referenced in the NVIM v.10.0 release. Not sure how you maintain this specific plugin in regards to breaking changes, but maybe a good idé would be to have a check for the version, until the NVIM 0.12 and depreciation of vim. tbl_flatten?

@busla
Copy link

busla commented May 20, 2024

yeah, let me upgrade to v10 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants