-
Notifications
You must be signed in to change notification settings - Fork 31
safe upgrade is upgrading the kernel #92
Comments
Snce we aren't providing kernel packages having a set kernel version will constantly need updating. Set a minimum required version and ensure the kernel we use is newer than this version. Fixes rcbops#92
Instead of running Additionally, is this just doing a string comparison? Maybe something like this...?
|
That Breaking into three separate checks:
|
Snce we aren't providing kernel packages having a set kernel version will constantly need updating. Set a minimum required version and ensure the kernel we use is newer than this version. Fixes rcbops#92
@byronmccollum any reason we have to check all 3 individually? |
If it's a string compare...wouldn't |
ahh true. it seems really inefficient to have to make 3 checks for 1 simple check though. |
Well, you need to check if But when |
http://docs.ansible.com/playbooks_variables.html#version-comparison-filters is what we really want; this is common enough it's already been solved with a single comparison filter. |
|
Variants don't break the loose version_compare (which uses distutils.version.LooseVersion, according to this: https://github.com/ansible/ansible/blob/devel/lib/ansible/runner/filter_plugins/core.py#L30), and IMO we definitely don't care about comparing variants because A) versioning across variants makes no sense, they're different types of kernels, and B) I can't imagine we have any interest whatsoever in using !generic Ubuntu kernels. So I say use the version_compare filter without strict=True and call it a job welld one. |
Well hot damn. Problem solved. |
You could recreate and pad out with 0's up to 3chars using zfill - ensuring that 014 > 004 in a string comparison, but thats probably more effort than its worth. I can't think of another sensible way to do this, do you want to make a PR against master with this changed to do the 3 checks. |
as pointed out by @Apsu...
...should do the trick. |
I still feel like it needs to account for the variant in some manner. @Apsu, do you think that it should also fail if the kernel is not |
PR #100 |
When the setup-common role runs a safe-upgrade is run to ensure all of the packages that are determined to be safely upgradable are up-to-date. Sadly the ansible apt module uses aptitude to perform this upgrade which attempts to bring in new kernels as they become available. Presently we are dep'ing on
kernel 3.13.0-34-generic
and the new stable kernel for Ubuntu 14.04.01kernel 3.13.0-35-generic
. It would seem that this is going to be a never ending battle of incremental kernel releases. If we are not going to be deploying a repository of frozen packages at this time we may need change the kernel check to set on the version and allow for kernel releases of >=34
.The text was updated successfully, but these errors were encountered: