Remove duplicated ansible.cfg configurations #1653

Merged
merged 1 commit into from Jan 5, 2017

Projects

None yet

4 participants

@major
Contributor
major commented Jan 4, 2017

This patch removes duplicated Ansible configurations that match OSA's
defaults. The ssh timeout was left in the file since it differs from
the OSA default (120 seconds in RPC vs 5 seconds in OSA).

RPC previously set forks at 15 for all deployments, but OSA uses a
safer mechanism to determine the maximum amount of forks. It sets a
hard limit of 10 but it lowers that limit to the maximum amount of
CPUs in the system if the CPU count is under 10.

Connects rcbops/rpc-openstack#1639

@major major Remove duplicated ansible.cfg configurations
This patch removes duplicated Ansible configurations that match OSA's
defaults. The ssh timeout was left in the file since it differs from
the OSA default (120 seconds in RPC vs 5 seconds in OSA).

RPC previously set forks at 15 for all deployments, but OSA uses a
safer mechanism to determine the maximum amount of forks. It sets a
hard limit of 10 but it lowers that limit to the maximum amount of
CPUs in the system if the CPU count is under 10.

Connects rcbops/rpc-openstack#1639
f9d8396
@alextricity25
Contributor

recheck_ceph

@alextricity25 alextricity25 self-assigned this Jan 5, 2017
@major
Contributor
major commented Jan 5, 2017 edited

That darned tempest test!

20:17:37         Response - Headers: {'status': '404', 'content-length': '109', 'content-location': 'http://172.29.236.100:8774/v2.1/6ed426f8fdce4d17954765d93e49009a/os-volumes/13a8a7a3-0e76-4beb-a08c-1941dc6863cd', 'x-compute-request-id': 'req-27a5e158-7836-4b7d-9307-3bdbf2f40a89', 'vary': 'X-OpenStack-Nova-API-Version', 'openstack-api-version': 'compute 2.1', 'connection': 'close', 'x-openstack-nova-api-version': '2.1', 'date': 'Wed, 04 Jan 2017 19:56:11 GMT', 'content-type': 'application/json; charset=UTF-8'}
20:17:37             Body: {"itemNotFound": {"message": "Volume 13a8a7a3-0e76-4beb-a08c-1941dc6863cd could not be found.", "code": 404}}

Thanks, @alextricity25. ;)

@major major self-assigned this Jan 5, 2017
@Frank-ZhangXin

LGTM 👍 when ceph test passed

-
-# SSH timeout
+# NOTE: The ssh timeout is increased here to 120 (OSA's default is 5) to
+# avoid transient ssh errors in some environments.
timeout = 120
@prometheanfire
prometheanfire Jan 5, 2017 Contributor

Is there a reason we need this timeout?

@prometheanfire
prometheanfire Jan 5, 2017 Contributor

Which transient errors? can they be fixed so we don't have to be 'special'?

@major
major Jan 5, 2017 Contributor

Not sure exactly what they were, but I remember @andymcc proposed those patches. We had some ssh connectivity issues to newly built containers and increasing the timeouts got us over the hump.

@prometheanfire
prometheanfire Jan 5, 2017 Contributor

Ya, looked at the blame/commit for it and it didn't explain it much.

@Frank-ZhangXin Frank-ZhangXin merged commit a720fe0 into master Jan 5, 2017

4 checks passed

ceph Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
swift Build finished.
Details
@Frank-ZhangXin Frank-ZhangXin deleted the mhayden-1639 branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment