Remove duplicated ansible.cfg configurations #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes duplicated Ansible configurations that match OSA's defaults. The ssh timeout was left in the file since it differs from the OSA default (120 seconds in RPC vs 5 seconds in OSA). RPC previously set forks at 15 for all deployments, but OSA uses a safer mechanism to determine the maximum amount of forks. It sets a hard limit of 10 but it lowers that limit to the maximum amount of CPUs in the system if the CPU count is under 10. Connects rcbops/rpc-openstack#1639
|
recheck_ceph |
alextricity25
approved these changes
Jan 5, 2017
|
That darned tempest test! Thanks, @alextricity25. ;) |
Frank-ZhangXin
approved these changes
Jan 5, 2017
|
|
||
| # SSH timeout | ||
| # NOTE: The ssh timeout is increased here to 120 (OSA's default is 5) to | ||
| # avoid transient ssh errors in some environments. | ||
| timeout = 120 |
There was a problem hiding this comment.
Is there a reason we need this timeout?
There was a problem hiding this comment.
Which transient errors? can they be fixed so we don't have to be 'special'?
There was a problem hiding this comment.
Not sure exactly what they were, but I remember @andymcc proposed those patches. We had some ssh connectivity issues to newly built containers and increasing the timeouts got us over the hump.
There was a problem hiding this comment.
Ya, looked at the blame/commit for it and it didn't explain it much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes duplicated Ansible configurations that match OSA's
defaults. The ssh timeout was left in the file since it differs from
the OSA default (120 seconds in RPC vs 5 seconds in OSA).
RPC previously set forks at 15 for all deployments, but OSA uses a
safer mechanism to determine the maximum amount of forks. It sets a
hard limit of 10 but it lowers that limit to the maximum amount of
CPUs in the system if the CPU count is under 10.
Connects rcbops/rpc-openstack#1639