Added "is null" and "is not null" comparators for Datetimes. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- they work a little bit different from other comparisons, since "HTML parameters don't usually work with a language-specific construct of nil". The passed in value for the filter is ignored and the comparison to nil/NULL is made instead. - for example, if you are filtering by parameters, you could 'add my_column_is_null' to the query string without a value - any value specified will be ignored. This addresses rcdilorenzo#62. It only adds the null comparators for DateTimes, however, it is straightforward to add them to other data types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They work a little bit different from other comparisons, since "HTML parameters don't usually work with a language-specific construct of nil". The passed in value for the filter is ignored and the comparison to nil/NULL is made instead.
For example, if you are filtering by parameters, you could 'add my_column_is_null' to the query string without a value - any value specified will be ignored.
This addresses #62. It only adds the null comparators for DateTimes, however, it is straightforward to add them to other data types.