Improve Python code and generated Makefiles #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as recommended by PEP-8.
- Simplify by using pattern rules and automatic variables - Use standard variable names - Fix default target to include 'o/' - Drop ccache
|
This looks fine. There is only one difference between Makefile and Makefile_osx, which is the -static option in LDFLAGS, is there a way to generate a single Makefile which checks whether the o/s is Linux or OSX to determine whether this flag should be included? |
for both Linux and macOS.
Of course, good point! I've added a commit to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Close rcedgar/muscle#7 .