Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-997 Reverts old ways of reading certificates by the TcpTransportLayer #1285

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

EncodePanda
Copy link
Contributor

@EncodePanda EncodePanda commented Aug 13, 2018

Overview

CORE-607 introduce new way of reading TLS ceritificates. This unofortunatlly broke the node as that new way of reading certificates does not work. This commit reverts those changes - bringing old way of reading certificates. Thix commit temporarly disables TransportLayer tests (they do not compile). Bringing those tests back is a matter of next PR - https://rchain.atlassian.net/browse/CORE-998

Integration tests are passing:

=================TEST SUMMARY RESULTS======================
PASS: peer1.rchain.coop: Metrics API http/tcp/40403 is available.
PASS: peer0.rchain.coop: Metrics API http/tcp/40403 is available.
PASS: peer1.rchain.coop: Peers count correct in node logs.
PASS: peer0.rchain.coop: Peers count correct in node logs.
PASS: peer1.rchain.coop: Rholang evaluation of files performed correctly.
PASS: peer0.rchain.coop: Rholang evaluation of files performed correctly.
PASS: peer0.rchain.coop: REPL loader success!
PASS: peer1.rchain.coop: Proposal of blocks for deployed contracts worked.
PASS: peer0.rchain.coop: Proposal of blocks for deployed contracts worked.
PASS: bootstrap.rchain.coop: Proposal of blocks for deployed contracts worked.
PASS: peer1.rchain.coop: No errors defined by "ERROR" in logs.
PASS: peer0.rchain.coop: No errors defined by "ERROR" in logs.
PASS: peer1.rchain.coop: No text of "RuntimeException" in logs.
PASS: peer0.rchain.coop: No text of "RuntimeException" in logs.
PASS ALL: All tests successfully passed
===========================================================
===========================================================

Which JIRA issue does this PR relate to? If there is not a JIRA issue addressing this work, please create one now and add the link here.

CORE-997

CORE-607 introduce new way of reading TLS ceritificates. This unofortunatlly broke the node as that new way of reading certificates does not work. This commit reverts those changes - bringing old way of reading certificates. Thix commit temporarly disables TransportLayer tests (they do not compile). Bringing those tests back is a matter of next PR.
def createTransportLayer(env: TcpTlsEnvironment): Task[TransportLayer[Task]] =
def createTransportLayer(env: TcpTlsEnvironment): Task[TransportLayer[Task]] = ???

/** TEMPORARLY postponed, see CORE-97
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be CORE-997, but we all know that :)

Copy link
Contributor

@jeremybusk jeremybusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (dev@d86c8e0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1285   +/-   ##
=====================================
  Coverage       ?     67%           
=====================================
  Files          ?     219           
  Lines          ?    8074           
  Branches       ?     531           
=====================================
  Hits           ?    5410           
  Misses         ?    2664           
  Partials       ?       0
Flag Coverage Δ
#blockstorage 93.44% <ø> (?)
#casper 80.51% <ø> (?)
#comm 24.6% <ø> (?)
#crypto 91.27% <ø> (?)
#node 2.15% <0%> (?)
#rholang 81.94% <ø> (?)
#roscala 79.1% <ø> (?)
#rspace 85.18% <ø> (?)
#shared 55.65% <ø> (?)
Impacted Files Coverage Δ
.../main/scala/coop/rchain/node/effects/package.scala 0% <ø> (ø)
...coop/rchain/comm/transport/TcpTransportLayer.scala 0% <ø> (ø)
node/src/main/scala/coop/rchain/node/node.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86c8e0...7562977. Read the comment docs.

@KellyatPyrofex KellyatPyrofex merged commit 377452f into rchain:dev Aug 14, 2018
@EncodePanda EncodePanda deleted the core-997 branch November 16, 2018 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants