Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCHAIN-4101: Add LMDB cache to Reporting API #2949

Merged
merged 6 commits into from
Jun 15, 2020

Conversation

tgrospic
Copy link
Collaborator

@tgrospic tgrospic commented Jun 5, 2020

Overview

Currently reporting API uses in-memory cache for EventLog for a block that is replayed. This PR introduces LMDB store for this cache.
This should decrease the use of heap memory which is needed for nodes supporting exchanges.

JIRA ticket:

https://rchain.atlassian.net/browse/RCHAIN-4101

Please make sure that this PR:

Bors cheat-sheet:

  • bors r+ runs integration tests and merges the PR (if it's approved),
  • bors try runs integration tests for the PR,
  • bors delegate+ enables non-maintainer PR authors to run the above.

@tgrospic tgrospic force-pushed the RCHAIN-4101-reporting-lmdb-cache branch from 90d643e to 827b8b6 Compare June 9, 2020 07:16
@tgrospic tgrospic requested review from zsluedem and nzpr June 9, 2020 07:29
@tgrospic tgrospic marked this pull request as ready for review June 9, 2020 07:29
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test needs to be modified

@tgrospic tgrospic changed the title RCHAIN-4101: Reporting API with LMDB cache RCHAIN-4101: Add LMDB cache to Reporting API Jun 10, 2020
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on observer-exch. It looks good to me

Copy link
Collaborator

@nzpr nzpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgrospic tgrospic force-pushed the RCHAIN-4101-reporting-lmdb-cache branch from 827b8b6 to ac19334 Compare June 15, 2020 06:26
@tgrospic
Copy link
Collaborator Author

tgrospic commented Jun 15, 2020

Reporting test is left disabled, fix will be in separate PR.

bors merge

bors bot added a commit that referenced this pull request Jun 15, 2020
2949: RCHAIN-4101: Add LMDB cache to Reporting API r=tgrospic a=tgrospic



Co-authored-by: Tomislav Grospic <grospic@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 15, 2020

Build failed:

@tgrospic
Copy link
Collaborator Author

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 15, 2020

Build succeeded:

@bors bors bot merged commit 9bc60e2 into rchain:dev Jun 15, 2020
@tgrospic tgrospic added the next-release Ready for next release label Jun 19, 2020
@tgrospic tgrospic added this to the v0.9.25 milestone Jun 19, 2020
@9rb 9rb removed the next-release Ready for next release label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants