-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCHAIN-4101: Add LMDB cache to Reporting API #2949
Conversation
90d643e
to
827b8b6
Compare
casper/src/test/scala/coop/rchain/casper/batch1/MultiParentCasperReportingSpec.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test needs to be modified
casper/src/test/scala/coop/rchain/casper/batch1/MultiParentCasperReportingSpec.scala
Outdated
Show resolved
Hide resolved
casper/src/test/scala/coop/rchain/casper/batch1/MultiParentCasperReportingSpec.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test on observer-exch. It looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
827b8b6
to
ac19334
Compare
Reporting test is left disabled, fix will be in separate PR. bors merge |
Build failed: |
bors retry |
Build succeeded: |
Overview
Currently reporting API uses in-memory cache for EventLog for a block that is replayed. This PR introduces LMDB store for this cache.
This should decrease the use of heap memory which is needed for nodes supporting exchanges.
JIRA ticket:
https://rchain.atlassian.net/browse/RCHAIN-4101
Please make sure that this PR:
Bors cheat-sheet:
bors r+
runs integration tests and merges the PR (if it's approved),bors try
runs integration tests for the PR,bors delegate+
enables non-maintainer PR authors to run the above.