Enable parallel runtimes #3299
Merged
Enable parallel runtimes #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two tests failing are inherited from block-merge branch, see #3277 |
nzpr
requested review from
zsluedem and
tgrospic
and removed request for
zsluedem
zsluedem
reviewed
Jan 21, 2021
| @@ -315,6 +315,16 @@ class ReplayRSpace[F[_]: Sync, C, P, A, K]( | |||
| comms.tailRecM(go).map(_.toOption) | |||
| } | |||
|
|
|||
| def spawn: F[IReplaySpace[F, C, P, A, K]] = { | |||
There was a problem hiding this comment.
I think we should keep the idea of manager to spawn new instance like KeyValueStoreManger and RUntimeManager.
|
I am thinking maybe I should follow your path and merge it first then clear things up later. Others can not easily code something into this feature branch now. |
zsluedem
approved these changes
Jan 23, 2021
There was a problem hiding this comment.
I am going to approve this one and let's polish it later with some other prs. I am sorry to be picky on the details with previous pr. I found that I should work with your pace instead of my pace which would make it easier for me to make pr on the branch. In that way , I can help you fix tests, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables parallel Runtimes to be constructed, which is a requirement for block merge.
This is a very simple minimal working fix, heavy refactoring of RSpace/ReplayRspace/RSpaceOps still needed.
The commit with adding syntax is not related to this, but as this PR is an attempt to split the huge #3238, it is small enough, so I decided to make it accompany the parallel runtimes commit.