Make tips return lca as well #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two tests failing are inherited from block-merge branch, see #3277 |
|
Is lca in this context the same as nearest common parent or nearest common state ? It's better to use a more complete and accurate name since l and c in lca can be misinterpreted or interpreted in multiple ways. It slips my mind now, but the last time we discussed this, we added a further clarification / qualification / specificity that was helpful and self-explanatory |
|
@9rb I think it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fork choice tips are ranked tips of the DAG. They do not make sense without knowing LCA, which were used to rank tips.
This PR package LCA next to tips returned by estimator.
This is useful for easier management of data and doing less work when preparing casper snapshot.