Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bugfixes #28

Merged
merged 2 commits into from
Apr 16, 2013
Merged

Small bugfixes #28

merged 2 commits into from
Apr 16, 2013

Conversation

mahnve
Copy link
Contributor

@mahnve mahnve commented Apr 15, 2013

I found two small bugs when I set up the server for a session.

  1. The square and cube question specs failed due to float rounding errors
  2. the original html_escape method did not work, so I changed it to use standard Haml escaping.

@mahnve
Takes care of rounding errors
9383e40 
Both Math.cbrt() and Math.sqrt() return floats with rounding
errors. Rounding off to 4 digits precision seems to be good enough and
makes the specs pass.
@mahnve
Uses Hamls built in html escaping
bfa242e
rchatley added a commit that referenced this pull request Apr 16, 2013
@rchatley
Merge pull request #28 from valtech/master
3d04349 
Small bugfixes
@rchatley rchatley merged commit 3d04349 into rchatley:master Apr 16, 2013
@rchatley
Copy link
Owner

Thanks Marcus

@mahnve
Copy link
Contributor Author

mahnve commented Apr 16, 2013

You're most welcome - thanks for creating the whole thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahnve @rchatley