Remove useless gitignore line #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHY: remove リポジトリ内にできてしまったファイルは意図して無視するべきです。 例えばバグなどにより意図せず異なるパスに生成してしまったファイルを無視してしまうと、 バグに気づけなくなるという副作用があります。
|
ありがとうございます！ |
takasehideki
approved these changes
Dec 8, 2022
takasehideki
added a commit
that referenced
this pull request
Dec 12, 2022
**Full Changelog**: v0.8.2...v0.8.3 * New features: none * Add arm32v7 support to mix rclex.prep.ros2 by @pojiro in #210 * Code Improvements/Fixes: * improve doc about docker env by @takasehideki in #208 * Remove useless gitignore line by @pojiro in #211 * insert sleep before publishing on example code (see #212) by @takasehideki in #213 * Bumps: * Bump elixir_make from 0.7.0 to 0.7.1 by @dependabot in #209 * Known issues to be addressed in the near future: * `publish/2` sometimes failed just after `create_publisher/3` in #212 * Lock `git_hooks` to 0.6.5 due to its issue in #138 * Bump to Humble Hawksbill in #114 * Release rcl nif resources when GerServer terminates in #160 * Note in this release: none
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY: remove
リポジトリ内にできてしまったファイルは意図して無視するべきです。
例えばバグなどにより意図せず異なるパスに生成してしまったファイルを無視してしまうと、
バグに気づけなくなるという副作用があります。